[Webkit-unassigned] [Bug 63966] [EFL] Add url bar to EWebLauncher.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63966





--- Comment #28 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-26 05:35:24 PST ---
> Tools/ChangeLog:3
> +        Reviewed by NOBODY (OOPS!).

The ChangeLog format has changed recently, and the "Reviewed by" line should come after the bug URL.

> Tools/EWebLauncher/entry.edc:29
> +            base: "font=Roman font_size=14 color=#000000 wrap=mixed";

A few patches ago you said you were going to make the font size 12. Why have you chosen 14 now?

> Tools/EWebLauncher/main.c:710
> +                full_url[len-1] = '\0';

This is not needed. sprintf(3) already adds the trailing null byte, as it comes automatically from the string you added.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.