[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64790





--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-07-25 23:36:35 PST ---
(In reply to comment #12)
> (From update of attachment 101478 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101478&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:345
> > +    gtk_main_do_event(const_cast<GdkEvent*>(event));
> 
> I still believe that it is incorrect to simply cast away the constness of this GdkEvent. It's probably more correct to make a copy of the event and send that.

We don't need to copy the event, gtk_main_do_event() doesn't modify the event at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.