[Webkit-unassigned] [Bug 64259] [EFL] Implement EditorClientEfl::respondToChangedContents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64259





--- Comment #10 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2011-07-25 06:42:38 PST ---
(From update of attachment 100303)
View in context: https://bugs.webkit.org/attachment.cgi?id=100303&action=review

>> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:125
>> +    Evas_Object* frame = ewk_view_frame_focused_get(m_view) ? ewk_view_frame_focused_get(m_view) : ewk_view_frame_main_get(m_view);
> 
> I would not call the getter twice here.

OK, should I do it this way:

Evas_Object* frame = ewk_view_frame_focused_get(m_view);
frame = frame ? frame : ewk_view_frame_main_get(m_view);

or get back to if?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.