[Webkit-unassigned] [Bug 64878] [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64878





--- Comment #10 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-07-24 19:32:11 PST ---
I'm fine with all the Qt parts, the only thing I'm not comfortable reviewing is the change in initialization of (In reply to comment #8)
> (In reply to comment #6)
> > 
> > > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:344
> > > +    ::glActiveTexture(GL_TEXTURE0);
> > 
> > Please ask Martin Robinson to review this.
> 
> Martin, could you review this part? Previously this was glActiveTexture(0) which is invalid and generated GL error GL_INVALID_ENUM

This is the only change to non-Qt-specific code; I'm fine with the Qt-specific changes after the latest patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.