[Webkit-unassigned] [Bug 64878] [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64878


Andrew Wason <rectalogic at rectalogic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101652|0                           |1
        is obsolete|                            |
 Attachment #101843|                            |review?
               Flag|                            |




--- Comment #7 from Andrew Wason <rectalogic at rectalogic.com>  2011-07-24 18:15:52 PST ---
Created an attachment (id=101843)
 --> (https://bugs.webkit.org/attachment.cgi?id=101843&action=review)
fix ANGLE compile flags

(In reply to comment #6)
> 
> Sorry, I can't let an overarching disabling of warnings in...
> We have to figure out a way to diable these for ANGLE files only,
> or to live with those warnings being outputted when we build the ANGLE files.

I defined a new compiler in QMAKE_EXTRA_COMPILERS, which is just QMAKE_CXX but with the extra warnings turned off and is used only for the ANGLE source files.

> All this should be under !CONTAINS(QT_CONFIG, opengles2)
>
> > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:32
> > +#if ENABLE(WEBGL) && !defined(QT_OPENGL_ES_2)
> 
> See previous comment. We can put this in the .pro file under
> contains(QT_CONFIG, opengles2)

Both are done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.