[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 24 10:25:13 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64580





--- Comment #64 from Adam Barth <abarth at webkit.org>  2011-07-24 10:25:13 PST ---
> I will be making the change to not trigger a download for synthetic clicks; I suppose I should be using isSimulated() to check?

I'm not sure that's right:  Document::createEvent calls MouseEvent::create(), which calls MouseEvent::MouseEvent(), which calls MouseRelatedEvent::MouseRelatedEvent(), which sets m_isSimulated(false).

I'm not sure we distinguish between synthetic and non-synthetic events in the DOM.  Another approach is to limit this action to occurring during a user gesture by checking ScriptController::isUserGesture.  That's consistent with how we handle other spam-like issues, which this appears to be.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list