[Webkit-unassigned] [Bug 64878] [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64878


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |noam.rosenthal at nokia.com




--- Comment #5 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-07-24 09:15:57 PST ---
> 
> 
> > > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:32
> > > +#if ENABLE(WEBGL) && !defined(QT_OPENGL_ES_2)
> > 
> > So, does this mean we use GraphicsContext3DQt for ES, and GraphicsContext3DOpenGL for desktop?
> > Maybe we should make this decision in the pro file rather than pollute the #ifdef space, especially in files shared by other ports.
> 
> Yes, all these changes are just for desktop. But I can't figure out how to determine if we are ES2 or desktop in the pro file - QT_OPENGL_ES_2 I believe would be defined in <Qt/qconfig.h> and that file is generated as part of the Qt configure/build process. If I could determine we are ES2 in the pro, then I can just not include the file in SOURCES in that case.

contains(QT_CONFIG, opengles2)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.