[Webkit-unassigned] [Bug 65064] Don't use group separators in formatting input[type=number]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65064


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101810|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-07-23 08:22:35 PST ---
(From update of attachment 101810)
View in context: https://bugs.webkit.org/attachment.cgi?id=101810&action=review

The patch have some issues.  But I think it's ok to land this.

> LayoutTests/ChangeLog:3
> +        Marked fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.

No.  It won't be flaky on Mac and Windows.
Flaky means that the result of a test is not stable without any change related to the test. In this case, we expect the test will fail by this change. So the test expectation should be:
  BUGWK65064 WIN MAC : fast/speech/input-appearance-numberandspeech.html = FAIL

> LayoutTests/platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:164
>  layer at (14,48) size 81x10 scrollWidth 172

This file is not listed in LayoutTests/ChangeLog.
Also, we should not update a render tree dump without updating the corresponding PNG in Chromium port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.