[Webkit-unassigned] [Bug 64981] export JSContextGetBacktrace as SPI in JSContextRefPrivate.h

Fri Jul 22 16:46:52 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64981

Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101780|review+                     |review-
               Flag|                            |

--- Comment #16 from Oliver Hunt <oliver at apple.com>  2011-07-22 16:46:52 PST ---
(From update of attachment 101780)
View in context: https://bugs.webkit.org/attachment.cgi?id=101780&action=review

> Source/JavaScriptCore/API/JSContextRef.cpp:211
> +        char levelStr[6];
> +        sprintf(levelStr, "#%d ", count);

should be snprintf if anything i guess, but...

> Source/JavaScriptCore/API/JSContextRef.cpp:226
> +        builder.append(levelStr);

Can you not just use UString::number() here instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.