[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable frames and iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257





--- Comment #50 from Vangelis Kokkevis <vangelis at chromium.org>  2011-07-22 16:21:42 PST ---
(From update of attachment 100879)
View in context: https://bugs.webkit.org/attachment.cgi?id=100879&action=review

> Source/WebCore/page/ChromeClient.h:268
> +            ScrollableFrameTrigger = 1 << 5,

Ports other than chromium set m_compositingTriggers = AllTriggers, meaning that they will also get composited iframes. Do we want that?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1351
> +bool RenderLayerCompositor::requiresCompositingForScrollableFrame(RenderView* view) const

Doesn't this method need to be called from requiresCompositingLayer()?  If not, what is it that guarantees that the iframe gets its own backing?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1907
> +void RenderLayerCompositor::forceCompostingForScrollableFrame(RenderView* view)

Typo: forceCompos_i_tingForScrollableFrame

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.