[Webkit-unassigned] [Bug 64897] Minimum Row Height For PopupListBoxes should platform-dependent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 22 15:47:50 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64897





--- Comment #18 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-07-22 15:47:50 PST ---
Attachment 101782 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/platform/chromium/PopupMenu..." exit_code: 1

Source/WebKit/chromium/public/WebWidget.h:129:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/src/WebViewImpl.h:107:  The parameter name "minimumRowHeight" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/chromium/PopupMenuChromium.h:178:  The parameter name "popupType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/WebPopupMenuImpl.h:76:  The parameter name "minimumRowHeight" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list