[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64580





--- Comment #48 from Alexey Proskuryakov <ap at webkit.org>  2011-07-22 14:17:28 PST ---
(From update of attachment 101763)
View in context: https://bugs.webkit.org/attachment.cgi?id=101763&action=review

> LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload.html:24
> +  var evt = document.createEvent("MouseEvent");
> +  evt.initMouseEvent('click', true, true);
> +  link.dispatchEvent(evt);

Ouch. I think that programmatically created mouse events should not be able to start download.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:795
> +void WebFrameLoaderClient::startDownload(const ResourceRequest& request, const String& suggestedName)
>  {
>      m_frame->startDownload(request);
>  }

How doesn't this unused argument no break the build? Ditto elsewhere.

> Source/WebKit2/WebProcess/WebPage/WebFrame.h:73
> +    void startDownload(const WebCore::ResourceRequest&, const String& = String());

I guess it's not a big deal to modify to WebFrame, but it doesn't seem necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.