[Webkit-unassigned] [Bug 64613] Use supported framebuffer renderbuffer mode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64613





--- Comment #10 from James Robinson <jamesr at chromium.org>  2011-07-22 12:38:48 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > If that fixes things, great.  Otherwise (or until then) we should be using DrawingBuffer.
> 
> Not sure I understand the objection to this patch though.  If appears to fix a path that's already there but is not coded the right way.  If a later change simplified things, that's even better, but why not fix now something we know is broken?

The patch isn't wrong, but it's a symptom of a greater issue that this code is using a completely untested codepath that breaks all the time.  We typically require tests for patches because patching untested code is a large waste of effort.  If this code was using the same code as the test canvas 2d path, then it wouldn't have to deal with this issue and it wouldn't suffer from the other breakages.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.