[Webkit-unassigned] [Bug 64897] Minimum Row Height For PopupListBoxes should platform-dependent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64897





--- Comment #16 from Fady Samuel <fsamuel at chromium.org>  2011-07-22 11:51:23 PST ---
(In reply to comment #15)
> (In reply to comment #13)
> > (From update of attachment 101640 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=101640&action=review
> > 
> > > Source/WebKit/chromium/public/linux/WebThemeEngine.h:150
> > > +    virtual int popupListBoxMinimumRowHeight() const { return 0; }
> > 
> > is this really a property of a theme engine?  often rendering style is pushed down to webkit.
> > maybe you should just have a static setter on WebPopupMenu for this?  put another way, does
> > it really need to be dynamically determined?  does it depend on a native theme engine like
> > uxtheme.dll or the gtk theme engine?
> 
> The size of hit targets for popup items can vary on certain Chromium platforms.


I will give this another approach. Since this is chromium-specific functionality

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.