[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64580





--- Comment #41 from Adam Barth <abarth at webkit.org>  2011-07-22 10:39:16 PST ---
> Indeed. How do you suggest we go about this? As you mentioned earlier, using a PLATFORM check or an ENABLE flag both seem ... kind of unreasonable for something like this.

I think the ENABLE macro is the lesser of two evils here.  My thinking process is the following:

1) We can't implement the entire feature in WebKit, so we'll need to be able to turn it on for some platforms but not others.
2) JSC doesn't support EnableAtRuntime yet, so we need a compile-time option in the IDL.
3) This feature isn't specific to the Chromium platform.  Chromium is just the first platform to implement the feature.  That means PLATFORM(CHROMIUM) isn't right.

That leaves an ENABLE macro.  The only problem with using an ENABLE macro is that the feature is small, but that's not really a big problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.