[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64580


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101736|review?                     |review-
               Flag|                            |




--- Comment #37 from Adam Barth <abarth at webkit.org>  2011-07-22 09:27:34 PST ---
(From update of attachment 101736)
View in context: https://bugs.webkit.org/attachment.cgi?id=101736&action=review

I like the new approach of not change ResourceRequestBase.  Two comments below.

> Source/WebCore/html/HTMLAnchorElement.cpp:512
> +            if (!referrer.isEmpty())
> +                request.setHTTPReferrer(referrer);

Don't we need to call shouldHideReferrer?

> Source/WebCore/html/HTMLAnchorElement.idl:29
> +        attribute [Reflect] DOMString download;

Looks like we still have the problem of this feature being half-implemented on non-Chromium ports.  We either need to fully implementing it or have it be invisible.  I'm not sure we can fully implement it without changing the embedders on those platforms, so we'll probably need to disable it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.