[Webkit-unassigned] [Bug 63013] [EFL] Page Cache was not Enabled(Enable Page Cache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63013


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101431|review?                     |review-
               Flag|                            |




--- Comment #53 from Antonio Gomes <tonikitoo at webkit.org>  2011-07-22 07:57:23 PST ---
(From update of attachment 101431)
View in context: https://bugs.webkit.org/attachment.cgi?id=101431&action=review

Needs one more interaction for clearance.

> Source/WebKit/efl/ewk/ewk_view.cpp:4595
> + * Restore cached page contents size.
> + * 
> + * This method must be called before WebCore::FrameView::layout().

How does the code ensure that? It is too error-prone, imo.

> Tools/ChangeLog:10
> +        When view port changed, zoom level was set. ewk_view_zoom_set() check zoom range
> +        but zoom range value was old one.
> +        So, I changed setting sequence.

typo: checkS*

Not sure if I understood this sentence.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.