[Webkit-unassigned] [Bug 65008] REGRESSION(r89535): Form reset doesn't redraw a file upload control

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65008


Kentaro Hara <haraken at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101711|1                           |0
        is obsolete|                            |




--- Comment #8 from Kentaro Hara <haraken at google.com>  2011-07-22 05:36:32 PST ---
(From update of attachment 101711)
View in context: https://bugs.webkit.org/attachment.cgi?id=101711&action=review

>> LayoutTests/fast/forms/file-input-reset-expected.html:16
>> +</p>
> 
> <div id=console> is not needed.

I added a selected file name here, in order to confirm that the file is really selected before being reset.

>> LayoutTests/fast/forms/file-input-reset.html:10
>> +<div id="console">
> 
> ditto.

Ditto.

>> LayoutTests/fast/forms/file-input-reset.html:24
>> +    click(reset.offsetLeft + reset.offsetWidth + 10, reset.offsetTop + reset.offsetHeight + 10); // Move a cursor out of the reset button.
> 
> Why don't you use getElementById('form').reset()?

I found that getElementById('form').reset() does not work. Even updateFromElement() is not invoked. This seems to be a regression too. Thus, I would like to commit this patch as it is, and then investigate the problem of reset() in the next patch.

>> Source/WebCore/ChangeLog:8
>> +        This is a regression caused by r98535. This patch fixes the code
> 
> r98535 -> r89535.
> Anyway, If you change the 1-list summary to "REGRESSION(r89535): Form reset doesn't redraw a file upload control", this sentence is not needed.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.