[Webkit-unassigned] [Bug 64923] [EFL] A method of defining open header list has been changed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64923





--- Comment #6 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-22 05:17:28 PST ---
I'm still not convinced by the arguments you have presented. What if you move the private headers to a private/ directory inside ewk? I'd be OK with this and I think it should be explicitly enough for you too.

> Source/WebKit/efl/ChangeLog:3
> +        [EFL] A method of defining open header list has been changed to an explicit manner.

That's not much in line with what I had in mind when I asked you to be less vague here. If one starts reading the ChangeLog file, this will probably make very little sense. What's an "open header", for a start? You should say something like "[EFL] Explicitly define which headers will be publicly installed".

> Source/WebKit/efl/ChangeLog:7
> +        different packages to clearly understand which header files contain publid API.

publid -> public

This would only help if people actually resorted to looking at the build system to check that (which means people working on webkit-efl itself, not people using it in other applications/packages), so this does not look very convincing.

> Source/WebKit/efl/ChangeLog:9
> +        modify cmake file by this change.

OK, this is a more compelling argument, as people will probably add internal headers more frequently than public ones. Still, neither of kind of addition should be frequent enough to justify such change.

> Source/WebKit/efl/ChangeLog:12
> +        because API in this file has been determined to internal purposes.

You could just say "Do not install ewk_util.h anymore, as it only has internal API". Plus, you need to adjust EWebKit.h accordingly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.