[Webkit-unassigned] [Bug 64731] Add MediaSource API to HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64731





--- Comment #18 from Aaron Colwell <acolwell at chromium.org>  2011-07-21 17:22:28 PST ---
(In reply to comment #16)
> (From update of attachment 101481 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101481&action=review
> 
> Two meta-issues:
> 
> 1) I think this is complex enough that is needs to be completely described in a spec before any changes are checked in.
> 

Ok. Here is my attempt at a W3C style spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.2/draft-spec/mediasource-draft-spec.html

Hopefully this is what you were looking for.

> 2) Even if this feature will only be enabled in Chromium, the code is in the main WebKit repository so we need tests in the same repository.
> 

Ok. I'll start working on this.

> 
> > Source/WebCore/html/HTMLMediaElement.cpp:1682
> > +    if (m_sourceState == SOURCE_CLOSED) {
> > +        scheduleEvent(eventNames().closeEvent);
> > +        return;
> > +    }
> 
> Shouldn't this be "webkitsourcecloseEvent" for symmetry?

Yes. Done.

> 
> > Source/WebCore/platform/graphics/MediaPlayer.cpp:144
> > +    virtual bool sourceAppend(const unsigned char* data, unsigned length) { return false; }
> 
> These parameter names aren't needed.

Done.

> 
> > Source/WebCore/platform/graphics/MediaPlayerPrivate.h:151
> > +    virtual bool sourceAppend(const unsigned char* data, unsigned length) { return false; }
> 
> These parameter names aren't needed.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.