[Webkit-unassigned] [Bug 64973] Add [Optional=CallWithDefaultValue] flag and use it in initXXXEvent declarations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64973


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101639|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-07-21 14:24:23 PST ---
(From update of attachment 101639)
View in context: https://bugs.webkit.org/attachment.cgi?id=101639&action=review

> Source/WebCore/dom/MessageEvent.idl:40
> -        [Custom] void initMessageEvent(in DOMString typeArg, in boolean canBubbleArg, in boolean cancelableArg, in SerializedScriptValue dataArg, in DOMString originArg, in DOMString lastEventIdArg, in DOMWindow sourceArg, in Array messagePorts);
> +        [Custom] void initMessageEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, in [Optional=CallWithDefaultValue] boolean canBubbleArg, in [Optional=CallWithDefaultValue] boolean cancelableArg, in [Optional=CallWithDefaultValue] SerializedScriptValue dataArg, in [Optional=CallWithDefaultValue] DOMString originArg, in [Optional=CallWithDefaultValue] DOMString lastEventIdArg, in [Optional=CallWithDefaultValue] DOMWindow sourceArg, in [Optional=CallWithDefaultValue] Array messagePorts);

I'd reformat this onto multiple lines.

> Source/WebCore/dom/MessageEvent.idl:45
> -        void initMessageEvent(in DOMString typeArg, in boolean canBubbleArg, in boolean cancelableArg, in SerializedScriptValue dataArg, in DOMString originArg, in DOMString lastEventIdArg, in DOMWindow sourceArg, in MessagePort messagePort);
> +        void initMessageEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, in [Optional=CallWithDefaultValue] boolean canBubbleArg, in [Optional=CallWithDefaultValue] boolean cancelableArg, in [Optional=CallWithDefaultValue] SerializedScriptValue dataArg, in [Optional=CallWithDefaultValue] DOMString originArg, in [Optional=CallWithDefaultValue] DOMString lastEventIdArg, in [Optional=CallWithDefaultValue] DOMWindow sourceArg, in [Optional=CallWithDefaultValue] MessagePort messagePort);

This too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.