[Webkit-unassigned] [Bug 64897] Minimum Row Height For PopupListBoxes should platform-dependent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64897





--- Comment #5 from Fady Samuel <fsamuel at chromium.org>  2011-07-21 12:40:50 PST ---
(From update of attachment 101521)
View in context: https://bugs.webkit.org/attachment.cgi?id=101521&action=review

>> Source/WebCore/platform/chromium/PlatformBridge.h:401
>> +    static int getPopupListBoxMinimumRowHeight();
> 
> we don't prefix getters with "get" in WebKit

But using 'get' is consistent with getThemePartSize in the same file. Is this also incorrect?

>> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1179
>> +
> 
> why don't you just ask PlatformBridge for the minimum row height here?

Done.

>> Source/WebCore/rendering/RenderTheme.h:170
>> +    virtual int popupListBoxMinimumRowHeight() const { return 0; }
> 
> this doesn't seem necessary

Removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.