[Webkit-unassigned] [Bug 64878] [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64878


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101609|review?                     |review-
               Flag|                            |




--- Comment #2 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-07-21 12:04:53 PST ---
(From update of attachment 101609)
View in context: https://bugs.webkit.org/attachment.cgi?id=101609&action=review

Comments inline.

> Source/WebCore/WebCore.pro:3641
> +    *g++* {
> +        QMAKE_CXXFLAGS += -Wno-unused-variable
> +        QMAKE_CXXFLAGS += -Wno-missing-noreturn
> +        QMAKE_CXXFLAGS += -Wno-unused-function
> +        QMAKE_CXXFLAGS += -Wno-parentheses
> +        QMAKE_CXXFLAGS += -Wno-reorder
> +        # g++ < 4.3 doesn't support -Wno-type-limits
> +        system( $$QMAKE_CXX --version | grep -e "\\<[4-9]\\.[3-9]\\.[0-9]" ) {
> +            QMAKE_CXXFLAGS += -Wno-type-limits
> +        }

Please explain :)

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:32
> +#if ENABLE(WEBGL) && !defined(QT_OPENGL_ES_2)

So, does this mean we use GraphicsContext3DQt for ES, and GraphicsContext3DOpenGL for desktop?
Maybe we should make this decision in the pro file rather than pollute the #ifdef space, especially in files shared by other ports.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:336
> +    // Always set to 1 for OpenGL ES.

Shouldn't we allow more if we're not in ES?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.