[Webkit-unassigned] [Bug 63237] [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 11:42:12 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63237


Aparna Nandyal <aparna.nand at wipro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aparna.nand at wipro.com




--- Comment #2 from Aparna Nandyal <aparna.nand at wipro.com>  2011-07-21 11:42:12 PST ---
Cause for this failure:
1. setHtml is done first and this  makes request to cache loader to load the image. This in turn makes an asynchronous request and even before the asynchronous call is completed setUrl is called.
2. setUrl does not cancel the previous request before loading the new url. Hence the problem. 

Would it be acceptable to cancel the request before actually going on to clear the frame like:

void QWebFrame::setUrl(const QUrl &url)
{
    d->frame->loader()->stopForUserCancel();
    clearCoreFrame(d->frame);
    ...

}

Alternately the test case would pass if we add waitForSignal between the setHtml and setUrl calls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list