[Webkit-unassigned] [Bug 63941] Compilation bug - gcc 4.6.0 and c++0x

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63941





--- Comment #7 from Loïc Yhuel <loic.yhuel_ext at softathome.com>  2011-07-21 11:39:08 PST ---
(In reply to comment #6)
> OK, I see what you mean, but still, if -Wall was added somewhere but the intention is to ignore c++0x support warnings (via -Wno-c++0x-compat), then the flags should be introduced together. I mean, whoever is adding -Wall should also add -Wno-c++0x-compat.
QtWebKit adds -Wno-* flags after its -Wall, but Fedora qmake.conf adds its -Wall, and obviously it doesn't know QtWebKit needs to ignore some warnings.

> Other alternatives are to remove -Werror when building on this configuration or add -Wno-c++0x-compat at the very end.
In fact it's not only -Wno-c++0x-compat, there are other -Wno-* (which could cause problems).
Adding at the very end would mean adding at least all -Wno-* to QMAKE_CXXFLAGS_RELEASE and QMAKE_CXXFLAGS_DEBUG instead of QMAKE_CXXFLAGS.

> 
> > So the patch removes second -Wall (the Fedora one), keeping the first (QtWebKit one).
> 
> I'm a bit lost here. What do you mean by "the Fedora one"?
qmake.conf from Fedora :
QMAKE_CFLAGS_RELEASE    += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2  -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables
The patch removes this -Wall, added by Fedora Qt configuration, and keeps the one from WebKit.pri.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.