[Webkit-unassigned] [Bug 64692] File upload control - filename text not aligned with button text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 09:46:26 PDT 2011


--- Comment #13 from dubroy at chromium.org  2011-07-21 09:46:26 PST ---
(From update of attachment 101452)
View in context: https://bugs.webkit.org/attachment.cgi?id=101452&action=review

>>> Source/WebCore/ChangeLog:7
>>> +        already accounted for by RenderButton::absoluteBoundingBoxRect().
>> Are you sure about this? Where? http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/RenderObject.cpp&l=1085
> You're right, that's wrong. I think the margin, border, and padding is accounted for by RenderBox::baselinePosition() (http://codesearch.google.com/#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/RenderBox.cpp&exact_package=chromium&q=baselinePosition&type=cs&l=3295).
> I verified this experimentally, but I can double-check the flow with a debugger.
> I'll fix the comment in a new patch.

Whoops, that should be RenderBlock::baselinePosition: http://codesearch.google.com/#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/RenderBlock.cpp&exact_package=chromium&q=baselinePosition&type=cs&l=5174

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list