[Webkit-unassigned] [Bug 64851] Optimize AnimationController::updateAnimations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64851


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101557|review?                     |review-
               Flag|                            |




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-07-21 08:41:33 PST ---
(From update of attachment 101557)
View in context: https://bugs.webkit.org/attachment.cgi?id=101557&action=review

> Source/WebCore/dom/NodeRenderingContext.cpp:287
> +    newRenderer->setAnimatableStyle(m_context.releaseStyle(), true); // setAnimatableStyle() can depend on renderer() already being set.

We try to avoid boolean parameters because they are hard to read at the call site, like this. Enums are preferred.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.