[Webkit-unassigned] [Bug 60910] might need to bundle the functions related to visual word break as a class (VisualWordBreaker)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60910


Van Lam <vanlam at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101416|0                           |1
        is obsolete|                            |
 Attachment #101518|                            |review?
               Flag|                            |




--- Comment #7 from Van Lam <vanlam at google.com>  2011-07-20 15:16:47 PST ---
Created an attachment (id=101518)
 --> (https://bugs.webkit.org/attachment.cgi?id=101518&action=review)
Revised fix (now without introducing the class hierarchy)

The patch is still big, but almost every diff in visible_units.cpp can be classified as either:
1) an access to a data member (which was previously passed into the function as an argument)
2) setting a data member for the callee to access
3) a function call in which fewer arguments are passed (because now commonly-passed arguments are saved as data members)
4) labeling previously static functions as member functions

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.