[Webkit-unassigned] [Bug 60910] might need to bundle the functions related to visual word break as a class (VisualWordBreaker)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60910





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-07-20 10:20:39 PST ---
(In reply to comment #3)
> Hi Ryosuke. I've implemented a Mac/Linux version but thought it would be better to split the refactoring of the Windows version and adding the Mac/Linux version into two patches.

Please upload your work in progress patch somewhere so I can see where you're headed.

> And can you clarify why we don't want to expose the base class definition in the header file? Thanks

We should strive to minimize dependency between cpp files as much as possible.  If you put the class declaration in the header file, then compiler have to parse and create AST for every cpp file that includes visbible_units.h.  Also, no other functions in visible_units are class members so this seems like an anti-pattern.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.