[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 09:54:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64790





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-07-20 09:54:15 PST ---
(From update of attachment 101478)
View in context: https://bugs.webkit.org/attachment.cgi?id=101478&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:213
> +        webkitWebViewBaseDidNotHandleKeyEvent(webkitWebViewBase, event.nativeEvent());

We don't need this method, we can just call gtk_main_do_event here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:339
> +    WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv;
> +    priv->shouldForwardEvent = TRUE;

This could be a single line webkitWebViewBase->priv->shouldForwardEvent = TRUE;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list