[Webkit-unassigned] [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63381





--- Comment #18 from Lukasz Slachciak <l.slachciak at samsung.com>  2011-07-19 22:52:46 PST ---
(From update of attachment 101387)
View in context: https://bugs.webkit.org/attachment.cgi?id=101387&action=review

>>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:2
>>> + * Copyright (C) 2011 Samsung Electronics
>> 
>> I don't think you should claim the copyright of the entire file you're copying the existing file and modifying it.
> 
> It seems like all of this is accidental, caused by git.

Initially the idea of logging was basing on the Source/WebCore/platform/gtk/LoggingGtk.cpp and even had note about it.
But patch was redesigned and now don't have common main code.

>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:13
>> + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
> 
> Also, this paragraph mentions Apple.

right, I'll fix this.
In fact I see a lot of errors like this in other files: Source/WebKit2/efl/MainEfl.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.