[Webkit-unassigned] [Bug 60910] might need to bundle the functions related to visual word break as a class (VisualWordBreaker)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60910





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-07-19 18:31:06 PST ---
(From update of attachment 101416)
View in context: https://bugs.webkit.org/attachment.cgi?id=101416&action=review

> Source/WebCore/editing/visible_units.h:99
> +class VisualWordBreakBase {

I don't think we want to expose this in the header file.

> Source/WebCore/editing/visible_units.h:175
> +class VisualWordBreakWindows : public VisualWordBreakBase {
> +    public:
> +        ~VisualWordBreakWindows() { }
> +        VisiblePosition leftWordPosition(const VisiblePosition& visiblePosition);
> +        VisiblePosition rightWordPosition(const VisiblePosition& visiblePosition);
> +
> +    private:
> +        void collectWordBreaksInBoxInsideBlockWithSameDirectionality();
> +        void collectWordBreaksInBoxInsideBlockWithDifferntDirectionality();
> +        void collectWordBreaksInBox();
> +};

I'm not sure a class hierarchy is the right way to approach this.  I wouldn't speculatively prepare for other platforms unless we already have some local patch that works on Mac and Unix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.