[Webkit-unassigned] [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63381





--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2011-07-19 15:23:53 PST ---
(From update of attachment 101387)
View in context: https://bugs.webkit.org/attachment.cgi?id=101387&action=review

Since I'm already here, I'm going to comment on the landed patch.

> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:2
> + * Copyright (C) 2011 Samsung Electronics

I don't think you should claim the copyright of the entire file you're copying the existing file and modifying it.

> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''

Also, this paragraph mentions Apple.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.