[Webkit-unassigned] [Bug 57154] [Qt] Make OpenGL symbol resolver transparent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57154





--- Comment #39 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-07-19 13:32:58 PST ---
> Actually, the existing indentation of the INCLUDEPATH directly above my CONFIG
> was wrong, so I fixed that when I added the new CONFIG. Both these should line
> up with the SOURCES further above (that you can't see in the diff),
> not with the filenames themselves that are the indented value of SOURCES.
>
OK. 

> I agree, but the existing definition of ASSIGN_FUNCTION_TABLE_ENTRY already used those names
> (see a few lines below in the diff).
> Should I fix the existing definition and my new definition, or leave my new definition
> consistent with the existing one?
Leave it consistent, that's ok.

> I'll remove QLatin1String.
I think with this and the #define we're good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.