[Webkit-unassigned] [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 19 11:55:46 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63381


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100864|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2011-07-19 11:55:46 PST ---
(From update of attachment 100864)
View in context: https://bugs.webkit.org/attachment.cgi?id=100864&action=review

> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:43
> +    // fulfill activatedChannels vector only once basing on names set in logEnv

This comment should probably read:

Fill activatedChannels vector only once based on names set in logEnv.

According to WebKit style guidelines, comments need to be a full sentence with a capital and period.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list