[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

Tue Jul 19 10:09:56 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64790

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101337|review?                     |review-
               Flag|                            |

--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-07-19 10:09:56 PST ---
(From update of attachment 101337)
View in context: https://bugs.webkit.org/attachment.cgi?id=101337&action=review

Looks good, but I have a few nits.

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:216
> +                                             reinterpret_cast<const GdkEventKey*>(event.nativeEvent()));

The indentation is off here and you should just do: &event.nativeEvent()->key or similar.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:330
> +                GTK_WIDGET(webViewBase),
> +                const_cast<GdkEventKey*>(keyEvent));

No need to break this line. It isn't right to simply cast away the constness here. The NativeWebKeyboardEvent is not expecting the GdkEventKey to change. Probably it's better to make a copy of the event and send that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.