[Webkit-unassigned] [Bug 64745] JSC GC lazy sweep does not inline the common cases of cell destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64745





--- Comment #5 from Darin Adler <darin at apple.com>  2011-07-18 14:41:07 PST ---
(From update of attachment 101205)
View in context: https://bugs.webkit.org/attachment.cgi?id=101205&action=review

> Source/JavaScriptCore/heap/MarkedBlock.cpp:98
> +                JSFinalObject* object = reinterpret_cast<JSFinalObject*>(cell);
> +                object->JSFinalObject::~JSFinalObject();

I would have done this as a one liner:

    reinterpret_cast<JSFinalObject*>(cell)->object->JSFinalObject::~JSFinalObject()

I also think it deserves a “why” comment, stating this is a special case for speed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.