[Webkit-unassigned] [Bug 37674] Implement sizes attribute for link tag from HTML5

Mon Jul 18 14:27:23 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=37674

Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101192|review?                     |review-
               Flag|                            |

--- Comment #17 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-07-18 14:27:23 PST ---
(From update of attachment 101192)
View in context: https://bugs.webkit.org/attachment.cgi?id=101192&action=review

This is not a complete implementation, since the validating parser isn't yet implemented. This means that if I set sizes = "foo 10x10", the icon.sizes.length would report a size of 2, instead of 1. I wonder if you could add the parser into this patch? This way, we wouldn't be landing incomplete functionality.

> LayoutTests/fast/dom/icon-size-property.html:14
> +      var icon=document.getElementById("rel-icon");

I think we need a few more tests here. Let's test for an empty sizes value, for instance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.