[Webkit-unassigned] [Bug 64728] TiledDrawingArea: Use tile sets to paint old content while rendering for a new scale.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64728





--- Comment #5 from Benjamin Poulain <benjamin at webkit.org>  2011-07-18 09:43:07 PST ---
(From update of attachment 101163)
View in context: https://bugs.webkit.org/attachment.cgi?id=101163&action=review

Quick comments:

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp:60
> +{
> +}

It'd be nice to have ASSERT(m_proxy) here so that fails early.

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:78
> +    TileMap& tiles() { return m_tiles; }

This is breaking the abstraction of TiledDrawingAreaTileSet.

It looks to me like TiledDrawingAreaProxy::updateTileBuffers() does not use any attribute so it could be a method of TiledDrawingAreaTileSet.
The case of TiledDrawingAreaProxy::tileBufferUpdateComplete() is a bit more tricky. If you manage to refactor it to avoid knowing about the tiles, the TiledDrawingAreaTileSet would be the only owner of m_tiles making a nicer abstraction.

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:82
> +    void setTile(const TiledDrawingAreaTile::Coordinate&, PassRefPtr<TiledDrawingAreaTile>);

Should this be private? It looks for me like the TiledDrawingAreaTileSet has the responsibility to manage its TiledDrawingAreaTile.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.