[Webkit-unassigned] [Bug 64262] Small speed up, which switches some virtual functions to inline ones.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64262





--- Comment #15 from Benjamin Poulain <benjamin at webkit.org>  2011-07-18 07:54:31 PST ---
(In reply to comment #14)
> > This should use the constructor initialiazation: m_isFixedSize(true);

My bad, I was not thinking straight, that code is obviously in the subclass.


> CSSPrimitiveValue(int ident)
>   : CSSValue(true)
>   , m_isQuirkValue(false)
>   , m_type(CSS_IDENT)
>   , m_hasCachedCSSText(false)
> {
>     m_value.ident = ident;
> }
> ... etc ...

Not necessarily. This make the internal variables m_isPrimitiveValue visible through the constructor which is not necessarily a good thing.

My comments were just wrong in this case. My point was that I would like this code to be split. I had a quick skim over the patch afterwards but I overlooked which variables come from which class. Just ignore me there :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.