[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 17 11:44:44 PDT 2011


--- Comment #30 from Adam Barth <abarth at webkit.org>  2011-07-17 11:44:43 PST ---
> Should this be conditional on PLATFORM(CHROMIUM) in that case?

Maybe add an ENABLE macro?  It seems somewhat silly to have an entire ENABLE macro for such a trivial feature.  There isn't any necessary connection between PLATFORM(CHROMIUM) and the presence of this API, so using that macro seems inappropriate.

> I can rename it (e.g. prepareResourceRequestForAnchorDownload) to make it more obvious what it does, or get rid of the function altogether and update the ResourceRequest in HTMLAnchorElement::handleClick. WDYS?

I'd rather the preparation of the resource request happened naturally in the course of FrameLoader handling the request.  It's not entirely clear to me why a ResourceRequest for an anchor download is a special case for FrameLoader.  How do the other folks who call startDownload handle this issue?

These are all detail points, however.  It's important that you also address Alexey's comments in Comment #28.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list