[Webkit-unassigned] [Bug 64666] [GTK] Fix selection of elements in a multi select list and remove an unnecessary include in WorkQueue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 17 10:29:14 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64666





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-07-17 10:29:14 PST ---
(From update of attachment 101112)
View in context: https://bugs.webkit.org/attachment.cgi?id=101112&action=review

> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:54
> +    bool isStatePresent = gdk_event_get_state(event, &state);
> +    if (!isStatePresent)

Might as well compress this into one line:

if (!gdk_event_get_state(event, &state))

or is there a reason why that isn't a good idea?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list