[Webkit-unassigned] [Bug 63553] SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63553





--- Comment #14 from Young Han Lee <joybro at company100.net>  2011-07-17 08:17:19 PST ---
(In reply to comment #12)
> (From update of attachment 100227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100227&action=review
> 
> I'm confused about your ChangeLog entry since it is the same entry like on another bug. r- because of the layouttest.

Would you check this again?

This changeLog could be difficult to understand, I will rewrite the log if you meant it, but the log is not the same with any other bug's changeLog.

Did you mean it is the same with the changeLog on the first patch I uploaded in this bug?

> 
> > LayoutTests/svg/animations/script-tests/animate-end-attribute.js:33
> > +    ok = isCloseEnough(rect.x.baseVal.value, 200, 0.2);
> > +    if (ok)
> > +        testPassed("rect.x.baseVal.value is almost 200");
> > +    else
> > +        testFailed("rect.x.baseVal.value is NOT almost 200, as expected");
> 
> Please don't do it manually we have a function called shouldBeCloseEnough() with three arguments. Take a look at other tests.

Done.

> 
> > LayoutTests/svg/animations/script-tests/animate-end-attribute.js:41
> > +    ok = isCloseEnough(rect.x.baseVal.value, 200, 0.2);
> > +    if (ok)
> > +        testPassed("rect.x.baseVal.value is almost 200");
> > +    else
> > +        testFailed("rect.x.baseVal.value is NOT almost 200, as expected");
> 
> Ditto.

Done.

> 
> > LayoutTests/svg/animations/script-tests/animate-end-attribute.js:49
> > +        ["animation", 2.0,    "rect", sample2],
> > +        ["animation", 3.0,    "rect", sample3]
> 
> You can reuse sample3 for 2s. Can you please add an animation step at 0s to verify that we start from baseVal?

Done.

> 
> > Source/WebCore/ChangeLog:9
> > +        calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
> > +        elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be before
> 
> Hm, wasn't it fixed with bug 63911?

No, bug 63911 doesn't fix a problem related to this bug.
The function is still returning 1, after the bug 63911 is applied.

> 
> > Source/WebCore/svg/animation/SVGSMILElement.cpp:833
> > +        return 1.f;
> 
> just use 1, no .f after numbers.

Done.

Thanks for the comments!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.