[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 20:23:05 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64580





--- Comment #20 from sadrul at chromium.org  2011-07-15 20:23:05 PST ---
(In reply to comment #18)
> (From update of attachment 101085 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101085&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:1237
> > +    String referrer = request.httpReferrer();
> > +    if (referrer.isEmpty())
> > +        referrer = m_outgoingReferrer;
> > +    if (SecurityOrigin::shouldHideReferrer(request.url(), referrer) || referrerPolicy == NoReferrer)
> > +        referrer = String();
> 
> Is this code duplicated from somewhere else in FrameLoader?  It would be nice not to duplicate.

It's a slightly modified piece of code from FrameLoader::loadURL and FrameLoader::urlSelected. But it doesn't look easily possible to refactor in a way that it can be used from loadURL/urlSelected too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list