[Webkit-unassigned] [Bug 64584] Avoid rounded rect corner-drawing overhead if no corners are visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64584


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100939|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-07-15 08:31:03 PST ---
(From update of attachment 100939)
View in context: https://bugs.webkit.org/attachment.cgi?id=100939&action=review

Let's see one more version. I'd also like to see an interactive testcase attached to the bug (maybe a roundrect inside a scrollable overflow region) so that behavior can be checked manually.

> Source/WebCore/ChangeLog:8
> +        No new tests, behavior is unaffected.

Well, behavior is affected, but not in a way that should affect visible rendering.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1425
> +    // If one of the corners falls outside the clip region, pretend it has no radius.

The comment should mention that this is done for performance reasons.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1450
> +        outerBorder.setRadii(adjustedOuterRadii);

You could avoid setting this if you didn't change any corners. I think you should also skip this entire block if rect is entirely inside the clip.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.