[Webkit-unassigned] [Bug 64525] MediaStream API: Release script objects when detaching document
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 15 02:32:23 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=64525
Tony Gentilcore <tonyg at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #100945|review?, commit-queue? |review-
Flag| |
--- Comment #2 from Tony Gentilcore <tonyg at chromium.org> 2011-07-15 02:32:23 PST ---
(From update of attachment 100945)
View in context: https://bugs.webkit.org/attachment.cgi?id=100945&action=review
r- for lack of test
> Source/WebCore/ChangeLog:10
> + No new tests because the patch is just a bug fix.
In WebKit, fixing a bug is usually a great reason to add a test. This is the sort of edge case that could easily break during future refactoring, so please add a test so we don't regress here.
> Source/WebCore/dom/Document.cpp:1778
> + if (mediaStreamFrameController)
If you prefer, a common idiom in WebKit is:
if (MediaStreamFrameController* mediaStreamFrameController = m_frame->mediaStreamFrameController())
mediaStreamFrameController->clearAllClients();
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list