[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64580


sadrul at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100918|0                           |1
        is obsolete|                            |
 Attachment #100918|review?                     |
               Flag|                            |
 Attachment #100933|                            |review?
               Flag|                            |




--- Comment #9 from sadrul at chromium.org  2011-07-14 22:58:42 PST ---
Created an attachment (id=100933)
 --> (https://bugs.webkit.org/attachment.cgi?id=100933&action=review)
directly call startDownload

I have made the change to call startDownload early directly from HTMLAnchorElement instead of going through urlSelected. Some notes:
 (1) I have tried to make sure that the ResourceRequest is properly updated with the referrer, user-agent etc. by adding FrameLoader::prepareResourceRequest
 (2) Added an optional 'String& suggestedName' parameter to WebCore::FrameLoaderClient::startDownload. It's currently unused in all implementations, but if this looks reasonable, I will hook it up at least for chromium.

I really appreciate the quick reviews. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.