[Webkit-unassigned] [Bug 64572] Initial implementation of calling WebScriptObject::callWebScriptMethod() via COM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 22:36:59 PDT 2011


--- Comment #10 from Anthony Johnson <anthony.johnson at flexsim.com>  2011-07-14 22:36:59 PST ---
(From update of attachment 100928)
View in context: https://bugs.webkit.org/attachment.cgi?id=100928&action=review

>>> Source/WebKit/win/WebScriptObject.cpp:36
>>> +#include "../../WebCore/html/canvas/ArrayBufferView.h"
>> Alphabetical sorting problem.  [build/include_order] [4]
> I don't know if this is best practices to include "../../Webcore...", but it was the only way I could figure out how to get the definition of the various ArrayBufferView types, as these headers are not copied to the distribution directory, which is the <WebCore...> directory. And should I intermingle these includes with the above in alphabetical order as the code guidelines say, or should they be out on their own?

I guess the review bot says they need to be with the includes above. I'll do that for the next patch update. Still, is this method of including kosher, or is the proper way to do it something else, i.e. should these headers be copied to the distribution directory <WebCore...>, in which case I don't know how to do that?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list