[Webkit-unassigned] [Bug 51897] Escape should clear search field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51897


Kentaro Hara <haraken at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100922|1                           |0
        is obsolete|                            |




--- Comment #14 from Kentaro Hara <haraken at google.com>  2011-07-14 21:38:48 PST ---
(From update of attachment 100922)
View in context: https://bugs.webkit.org/attachment.cgi?id=100922&action=review

>> LayoutTests/fast/forms/input-search-press-escape-key.html:28
>> +    eventSender.keyDown("escape");
> 
> Why can’t we just use "\x1B" here?

Great idea! I fixed it and removed all per-platform changes in EventSender.

>> Source/WebCore/html/SearchInputType.cpp:104
>> +        return;
> 
> Why are we not calling TextFieldInputType::handleKeydownEvent in this case?

Fixed.

>> Source/WebCore/html/SearchInputType.cpp:113
>> +        TextFieldInputType::handleKeydownEvent(event);
> 
> We'd normally use a return here instead of an else.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.