[Webkit-unassigned] [Bug 51897] Escape should clear search field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51897





--- Comment #11 from Darin Adler <darin at apple.com>  2011-07-14 20:35:43 PST ---
(From update of attachment 100922)
View in context: https://bugs.webkit.org/attachment.cgi?id=100922&action=review

> LayoutTests/fast/forms/input-search-press-escape-key.html:28
> +    eventSender.keyDown("escape");

Why can’t we just use "\x1B" here?

> Source/WebCore/html/SearchInputType.cpp:104
> +        return;

Why are we not calling TextFieldInputType::handleKeydownEvent in this case?

> Source/WebCore/html/SearchInputType.cpp:113
> +        event->setDefaultHandled();
> +    } else
> +        TextFieldInputType::handleKeydownEvent(event);

We'd normally use a return here instead of an else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.